Raptorox/rat
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

don't repeat l/rhs in eval

Browse source
This commit is contained in:
Raptorox 2026-05-21 17:40:53 +02:00
parent 8c507cb1da
commit a887bf4b3e
No known key found for this signature in database
GPG key ID: 8B3556FC3ED1F6D8
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/eval.rs
View file

@ -20,13 +20,16 @@ impl Evaluator {
} }
}, },
Expr::Binary { op, left, right } => { Expr::Binary { op, left, right } => {
let lhs = self.eval_expr(*left);
let rhs = self.eval_expr(*right);
match op { match op {
BinaryOp::Add => self.eval_expr(*left) + self.eval_expr(*right), BinaryOp::Add => lhs + rhs,
BinaryOp::Sub => self.eval_expr(*left) - self.eval_expr(*right), BinaryOp::Sub => lhs - rhs,
BinaryOp::Mul => self.eval_expr(*left) * self.eval_expr(*right), BinaryOp::Mul => lhs * rhs,
BinaryOp::Div => self.eval_expr(*left) / self.eval_expr(*right), BinaryOp::Div => lhs / rhs,
BinaryOp::Mod => self.eval_expr(*left) % self.eval_expr(*right), BinaryOp::Mod => lhs % rhs,
BinaryOp::Exp => self.eval_expr(*left).pow(self.eval_expr(*right) as u32) // probably shouldn't cast like that BinaryOp::Exp => lhs.pow(rhs as u32) // probably shouldn't cast like that
} }
}, },
expr => panic!("can't eval expression: {expr:?}") expr => panic!("can't eval expression: {expr:?}")